Ensure IMAGE_TAG_EXT is present for all intermediate images
What does this MR do?
Previously the gitlab-rails-ee
and other jobs could fail if IMAGE_TAG_EXT
were set to an arbitrary value, as done in the review-build-cng
GitLab Rails job.
IMAGE_TAG_EXT
is always appended to an image tag in
build-scripts/build.sh
when building an image. Even though
intermediate tags don't necessarily need IMAGE_TAG_EXT
, they
are always built with them. Append the IMAGE_TAG_EXT
for
the following build arguments:
BASE_IMAGE
GM_IMAGE
EXIFTOOL_IMAGE
RUBY_VERSION
BOOTSNAP_IMAGE
TAG
PYTHON_TAG
Test pipeline with IMAGE_TAG_EXT
set to -5e5960f94af
: https://gitlab.com/gitlab-org/build/CNG/-/pipelines/1043468889
Related issues
Relates to #734 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Integration tests added to GitLab QA -
The impact any change in container size has should be evaluated -
New dependencies are managed with dependencies.io
Edited by Jason Plum