Add Sidekiq concurrency option
What does this MR do?
Add Sidekiq concurrency option to the bin/sidekiq-cluster
CLI
The min concurrency and max concurrency option will be removed in 17.0
https://docs.gitlab.com/ee/update/deprecations.html#min-concurrency-and-max-concurrency-in-sidekiq-options.
The replacement is to use a new and simpler concurrency
flag which
sets the same concurrency value for all Sidekiq processes.
The GitLab Sidekiq chart is already passing the SIDEKIQ_CONCURRENCY env var https://gitlab.com/gitlab-org/charts/gitlab/-/blob/5a8714f0b20198ed1af50fd089b548fa21cfcf54/charts/gitlab/charts/sidekiq/templates/deployment.yaml#L197-198, so here we are just passing the value in a different flag.
Related issues
gitlab-com/gl-infra/scalability#2760 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Integration tests added to GitLab QA -
The impact any change in container size has should be evaluated -
New dependencies are managed with dependencies.io