Skip to content

Add gomplate to UBI-8 gitlab-base image

Stan Hu requested to merge sh-add-gomplate-gitlab-base into master

gitlab-org/charts/gitlab!3805 (merged) added a dependency of gomplate inside gitlab-base. While the Debian-based images ships with gomplate with gitlab-base (!1134 (merged)), UBI-8 does not. To fix this problem, add gomplate to fix the registry chart.

Related issues

Testing

$ docker run -it registry.gitlab.com/gitlab-org/build/cng/gitlab-base:sh-add-gomplate-gitlab-base-ubi8 gomplate -h
Begin parsing .tpl templates from /etc
Process text files with Go templates

Usage:
  gomplate [flags]

Flags:
  -d, --datasource datasource      datasource in alias=URL form. Specify multiple times to add multiple sources.
  -H, --datasource-header header   HTTP header field in 'alias=Name: value' form to be provided on HTTP-based data sources. Multiples can be set.
  -c, --context datasource         pre-load a datasource into the context, in alias=URL form. Use the special alias `.` to set the root context.
      --plugin strings             plug in an external command as a function in name=path form. Can be specified multiple times
  -f, --file file                  Template file to process. Omit to use standard input, or use --in or --input-dir (default [-])
  -i, --in string                  Template string to process (alternative to --file and --input-dir)
      --input-dir directory        directory which is examined recursively for templates (alternative to --file and --in)
      --exclude strings            glob of files to not parse
      --include strings            glob of files to parse
  -o, --out file                   output file name. Omit to use standard output. (default [-])
  -t, --template strings           Additional template file(s)
      --output-dir directory       directory to store the processed templates. Only used for --input-dir (default ".")
      --output-map string          Template string to map the input file to an output path
      --chmod string               set the mode for output file(s). Omit to inherit from input file(s)
      --exec-pipe                  pipe the output to the post-run exec command
      --left-delim delimiter       override the default left-delimiter [$GOMPLATE_LEFT_DELIM] (default "{{")
      --right-delim delimiter      override the default right-delimiter [$GOMPLATE_RIGHT_DELIM] (default "}}")
      --experimental               enable experimental features [$GOMPLATE_EXPERIMENTAL]
  -V, --verbose                    output extra information about what gomplate is doing
      --config string              config file (overridden by commandline flags) (default ".gomplate.yaml")
  -h, --help                       help for gomplate

Also verified with:

global:
  image:
    tagSuffix: -ubi8
registry:
  enabled: true
  init:
    image:
      tag: sh-add-gomplate-gitlab-base

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Stan Hu

Merge request reports

Loading