Skip to content

gitlab-base: Bring gitlab-logger image tag suffix back

João Alexandre Cunha requested to merge fix-logger-image-suffix into master

What does this MR do?

gitlab-base: Bring gitlab-logger image tag suffix back

In 6f93d54e we attempted to pull the correct CONTAINER_VERSION but without the suffix. This caused the image to not be found:

https://gitlab.com/gitlab-org/security/charts/components/images/-/jobs/7354796109#L109

Changelog: fixed

Symptom

gitlab-logger job output

Image information for <REGISTRY>/gitlab-logger:ac9cc71c5c58ed0329805a9915ae4cecd8e62280-0aa6926b

gitlab-base:

--build-arg "GOMPLATE_TAG=${gomplate_version}${IMAGE_TAG_EXT}"
--build-arg "GITLAB_LOGGER_IMAGE=${CI_REGISTRY_IMAGE}/gitlab-logger:${logger_target_version}"
-t <REGISTRY>/gitlab-base:d70ed7a184c6c96ed63cbeb8416f3d6f5c199be0-0aa6926b-buildx
--build-arg GITLAB_VERSION=0aa6926b420ebe3c8af0a1e28dc9ce078f0037c9
--build-arg GOMPLATE_TAG=77a4849732e035fbf13b0211f1fcba930ea60853-0aa6926b
--build-arg GITLAB_LOGGER_IMAGE=<REGISTRY>/gitlab-logger:ac9cc71c5c58ed0329805a9915ae4cecd8e62280

Expectation

--build-arg GOMPLATE_TAG=77a4849732e035fbf13b0211f1fcba930ea60853-0aa6926b
--build-arg GITLAB_LOGGER_IMAGE=<REGISTRY>/gitlab-logger:ac9cc71c5c58ed0329805a9915ae4cecd8e62280-0aa6926b

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by João Alexandre Cunha

Merge request reports

Loading