Skip to content

Fix revision fetching to work outside our dev instance

DJ Mountney requested to merge fix-revision into master

What does this MR do?

Fixes the REVISION field used in the GitLab help page. We were hardcoding something called GITLAB_EDITION, which was set in such a way that it only worked for builds on dev.

At the same time, I noticed that it was just completely broken for ubi images. See the key to getting the revision (the sha256) is that artifacts from the gitlab api include it in the first level folder within the tar. (<projectname>-<requestedref>(-<computedsha>)). The computed sha is added if requestref doesn't match the computed sha I believe.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by DJ Mountney

Merge request reports