Skip to content

Make gitaly's process-wrapper handle Praefect also

Balasankar 'Balu' C requested to merge gitaly-wrapper-for-praefect into master

What does this MR do?

Instead of using a ConfigMap hacked in via args to run Praefect, make gitaly's process-wrapper handle both Gitaly and Praefect services, since we are using the same Docker image for both Gitaly and Praefect.

The charts counterpart which will set necessary variables is done at gitlab-org/charts/gitlab!2119 (merged)

Related issues

gitlab-org/charts/gitlab#2434 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Jason Plum

Merge request reports