Skip to content

Add variable GITLAB_BUNDLE_GEMFILE to specify gemfile

vincent stchu requested to merge (removed):use-bundle-config-to-specify-gemfile into master

What does this MR do?

As Jihu begins to use jh/Gemfile, we need a way to specify the Gemfile for bundle to make sure we can build correct CNG images.

To achieve this, I add a variable GITLAB_BUNDLE_GEMFILE:

  • When GITLAB_BUNDLE_GEMFILE is not set, nothing will be changed when build docker images
  • When GITLAB_BUNDLE_GEMFILE is set like 'jh/Gemfile', a bundle config will be executed to change the Gemfile path when build gitlab-rails image.

Related issues

gitlab-org/gitlab#338469 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by vincent stchu

Merge request reports