Skip to content

feat(workhorse): graceful shutdown is default

Steve Xuereb requested to merge feat/workhorse-graceful-shutdown-default into master

What does this MR do?

What

Remove the feature flag GITLAB_WORKHORSE_EXEC to always use exec so gitlab-workhorse is PID 1 so that SIGTERM is always sent to gitlab-workhorse and triggers graceful termination.

Why

In !972 (merged) we added a new feature flag so that gitlab-workhorse is PID 1 and get's gracefully killed.

We've rolled out that feature flag in gprd and we are seeing positive results where we no longer seeing 502 errors during container shutdown.

We want this to be default behvior now that we saw this doesn't have any user face issues.

Related issues

Reference: https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/15497

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Steve Xuereb

Merge request reports