Skip to content

fix(mailroom): termination to pid 1

Steve Xuereb requested to merge fix/mailroom-pid into master

What does this MR do?

What

Move mailroom to be PID 1 so that termination signals are sent to the mailroom process rather then the bash process

Why

SIGTERM is sent to PID 1 automatically to the container by Kubernetes/CRI, however mailroom is not PID 1 but it's wrapped with /bin/sh becuase CMD is used with shell from. Using the array notation means that it will use the exec form.

Related issues

Reference: gitlab-org/charts/gitlab#3249 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Jason Plum

Merge request reports