Skip to content

SessionServer Improvements

Johannes Reppin requested to merge belfhi/gitlab-runner:main into main
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do?

Previously, the chart enabled the use of an ingress with the sessionServer. This MR adds the ability to use TLS. It also changes the templating of the metadata.annotations since it is a map and not a string. The annotations are important since cert-manager uses them and ingress TLS is often used in combination with it.

Also, in entrypoint configmap sh is used to call the function set-session-server-address, but the shebang of the function is #!/bin/bash and it uses bash syntax ( if [[ ... ]]), so bash is needed.

Why was this MR needed?

Ingress without a TLS section is not recommended and sh does not work in combination with [[ ]] which is a bash feature.

What's the best way to test this MR?

deploy gitlab-runner with sessionServer and use cert-manager to create an ingress TLS certificate.

What are the relevant issue numbers?

Edited by Johannes Reppin

Merge request reports