Skip to content

Draft: Set ENABLE_PUMA_NAKAYOSHI_FORK to true by default

Aleksei Lipniagov requested to merge alipniagov/set-nakayoshi-env-var-default-true into master

What does this MR do?

Enables nakayoshi_fork for Puma.

Because the related incident was resolved (gitlab-com/gl-infra/production#3370 (closed)) and the source of the issue was patched (gitlab-org/gitlab!52177 (merged)), and we also established a single name for the env variable(gitlab-org/gitlab-development-kit!1775 (diffs), gitlab-org/build/CNG!587 (diffs), gitlab-org/omnibus-gitlab!4941 (diffs)), we are ready to set ENABLE_PUMA_NAKAYOSHI_FORK: "true" by default.

See: gitlab-org/gitlab#288042 (comment 494061932)

Related:

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • [-] Tests added
  • [-] Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Aleksei Lipniagov

Merge request reports