Skip to content

[shared-secrets chart] If Secret key does not exist, patch it in

Mitchell Nielsen requested to merge 1684-shared-secrets-check-keys into master

What does this MR do?

If Secret key does not exist, patch it in

Currently, if the Secret exists by name, then shared secrets will skip the secret and move on. This is not desirable for situations in which a new key is added to a Secret, in which case shared-secrets would not notice and move along.

This checks to ensure that the given key exists in the Secret. If not, it will use kubectl patch to add the desired key and value.

Note that this does not confirm that the desired value matches the current value. It is only checking the keys.

Related issues

Closes #1684 (closed) Related to #2310

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened

Closes #1684 (closed)

Edited by Mitchell Nielsen

Merge request reports

Loading