Skip to content

[shared-secrets job] Fix support for an existing ServiceAccount

Mitchell Nielsen requested to merge fix-sharedsecrets-job-serviceaccount into master

What does this MR do?

Fixes support for an existing ServiceAccount on the shared-secrets job by removing the if block around it. The referenced template used to calculate the value handles the required logic.

Related issues

Closes #2760 (closed)

Testing plan

Add the following values to a file (like build/test.values.yaml):

shared-secrets:
  rbac:
    create: false
  serviceAccount:
    create: false
    name: myexistingserviceaccount

Confirm that the serviceAccount is set as expected on the shared-secrets job:

$ helm template test . -f build/test.values.yaml --set certmanager-issuer.email=no@no.com --show-only templates/shared-secrets/job.yaml | grep serviceAccountName
      serviceAccountName: myexistingserviceaccount

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports