Skip to content

Fix extraEnv configuration for GitLab Pages Chart

John Skarbek requested to merge jts/fix-pages-envs into master

What does this MR do?

  • Ensures that the extraEnv is applied to the running container of the Pod

Related issues

Found during investigative issue confirming configurations of our omnibus installations with our newly deployed Kubernetes installation for .com: gitlab-com/gl-infra/delivery#1972 (comment 728621284)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Testing

On any commit that does not include this MR:

gitlab:
  gitlab-pages:
    extraEnv:
      FOO: bar

Inspecting the deployment for <release_name>-gitlab-pages would result in FOO=bar only being applied to the initContainers. After this MR, they are appropriately added to all containers.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by John Skarbek

Merge request reports