RSpec: DRY replacement for common certmanager-issuer values
requested to merge 3409-rspec-examine-all-default_values-definitions-for-dry-replacement into master
What does this MR do?
The certmanager-issuer configuration is required to render the Helm chart, and is therefore often used in our RSpec tests. To avoid repetition, all tests have been adapted to use HelmTemplate.certmanager_issuer
or HelmTemplate.with_certmanager_issuer
instead of re-defining the certmanager-issuer configuration.
Related issues
Closes #3409 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes - not applicable
-
Documentation created/updated -
Tests added - not applicable
-
Integration tests added to GitLab QA - not applicable
-
Equivalent MR/issue for omnibus-gitlab opened - not applicable
-
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.- not applicable
Edited by Clemens Beck