Provide option to configure kas redis using global.redis.kas
What does this MR do?
This MR provides the option to configure the gitlab-kas redis using global.redis.kas
.
Currently gitlab-kas
's redis is configured in the following order of priority
-
.Values.global.redis.sharedState
if defined -
.Values.global.redis.host
as final fallback
This MR changes it to
-
.Values.global.redis.kas
if defined -
.Values.global.redis.sharedState
if defined -
.Values.global.redis.host
as final fallback
Related issues
gitlab-com/gl-infra/scalability#2651 (comment 1699965047)
Author checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added/updated -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -- NA since gitlab-kas redis is already configured separately (gitlab-com/gl-infra/scalability#2651 (comment 1699981991)) -
Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes) -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Plum