Skip to content

Support Redis cluster configuration for registry rate-limiting

Jaime Martinez requested to merge 5650-support-registry-redis-cluster into master

What does this MR do?

While testing the Redis rate-limiting configuration on pre (gitlab-com/gl-infra/k8s-workloads/gitlab-com!3727 (merged)), we found that the chart will append a port to the last host on a list like the following:

Before

values.yml:

  redis:
    rateLimiting:
      enabled: true
      host: 'redis.one.example.com:6379, redis.two.example.com:6379'

Rendered configuration:

    redis:
      ratelimiter:
        enabled: true
        addr: "redis.one.example.com:6379, redis.two.example.com:6379:6379"

To support using a Redis cluster, we want to add a subsection registry.redis.rateLimiting.cluster to the registry configuration.

After

  redis:
    rateLimiting:
      enabled: true
      cluster:
        - host: 'redis.one.example.com'
          port: 6379
        - host: 'redis.two.example.com'

Rendered configuration:

    redis:
      ratelimiter:
        enabled: true
        addr: "redis.one.example.com:6379, redis.two.example.com:6379"

Related issues

Closes Registry: Add support for Redis cluster addresses (#5650 - closed)

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

  • Merge Request Title and Description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline.
  • Documentation created/updated.
  • Tests added/updated, and test plan for scenarios not covered by automated tests.
  • Equivalent MR/issue for omnibus-gitlab opened.

Reviewers checklist

Edited by Jaime Martinez

Merge request reports

Loading