Sync Gitaly graceful shutdown with pod
What does this MR do?
Adds a new gracefulRestartTimeout Helm value with a default of 25 seconds.
Currently the pod terminationGracePeriodSeconds is statically configured at 30 seconds, however the Gitaly graceful_restart_timeout value defaults to 1 minute. This leads to Kubernetes killing the pod in certain circumstances before Gitaly terminating gracefully.
The gracefulRestartTimeout variable will set both the Gitaly and Pod grace period during shutdown, with a margin of 5 seconds added to the pod value.
| Type | Existing value | New value |
|---|---|---|
| Pod | 30s | 30s |
| Gitaly | 1m | 25s |
Related issues
tableflip-free: Revisit client auto-retry window (gitlab-org/gitaly#6209 - closed)
Deploy Gitaly + Kubernetes in pre environment (gitlab-org/gitaly#6007 - closed)
Author checklist
For general guidance, please follow our Contributing guide.
Required
For anything in this list which will not be completed, please provide a reason in the MR discussion.
-
Merge Request Title and Description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
MR has a green pipeline. -
Documentation created/updated. -
Tests added/updated, and test plan for scenarios not covered by automated tests. -
Equivalent MR/issue for omnibus-gitlab opened.
Reviewers checklist
-
MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab. -
Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab Chart.