Remove 'ci_jwt_signing_key' secret migrated to ApplicationSetting
What does this MR do?
The secret was actually never used:
- Introduced in gitlab-org/gitlab!34249 (diffs) and !1318 (diffs)
- The first MR was reverted by gitlab-org/gitlab!34646 (diffs) but the second was never reverted
- The final solution was to add an
ApplicationSetting
: gitlab-org/gitlab!43950 (merged)
The secret documentation is also removed from gitlab
at gitlab-org/gitlab!165829 (merged), and omnibus-gitlab
at gitlab-org/omnibus-gitlab!7930 (merged).
Related issues
gitlab-org/gitlab#451151 (closed)
Author checklist
For general guidance, please follow our Contributing guide.
Required
For anything in this list which will not be completed, please provide a reason in the MR discussion.
-
Merge Request Title and Description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
MR has a green pipeline. -
Documentation created/updated. -
Tests added/updated, and test plan for scenarios not covered by automated tests. -
Equivalent MR/issue for omnibus-gitlab opened.
Reviewers checklist
-
MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab. -
Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab Chart.
Edited by Rémy Coutable