Skip to content

Better Offline Scanning Quality Support

Benjamin Zeigler requested to merge sololegends/codequality:sololegends-offline-scanning-fixes into master

Closes gitlab-org/gitlab#228874 (closed)

Overview

Adds better, easier, offline scanning support for code quality scanning.

What does this MR do?

Cleans up the CODECLIMATE_IMAGE variable for more obvious flow and readability. (No change in function)

Also adds an environment variable pass through to the codeclimate image for setting the engine docker image prefix. The variable to be passed through is CODECLIMATE_PREFIX. Which is the prefix for all docker pull ${engine} calls.

This will eliminate the need for a user to compile their own Codeclimate docker image to run the scans totally air-gapped.

NOTE: This merge will be dependent on this codeclimate pull request

What are the relevant issue numbers?

Gitlab-EE Issue #11522

Testing

  • Tested in an air-gapped environment using a local registry (SUCCESS)
  • Tested swapping this change's build docker image in for the codequality:0.85.9, no configuration change. (SUCCESS)
    • Meaning this change will NOT effect current configurations

cc @drewcimino @iamricecake @morefice

Edited by Daniel Marquard

Merge request reports