Skip to content

Allow failure for MR approval state lookup (non-premium)

Shaun Duncan requested to merge shaun35/cli:approvers-view into main

Description

This modifies the behavior for approval state lookup for merge requests such that failures to obtain approval state status are ignored and glab mr view will dispaly the normal output. I've included a comment in the change to explain this choice, but the gist is that the client library cannot allow distinguishing between a valid "0" and a missing/empty value for approvals_before_merge.

Related Issue

Resolves #1023 (closed)

How Has This Been Tested?

  • GITLAB_TOKEN=<my_token> EDITOR="" VISUAL="" make test
  • GITLAB_TOKEN=<my_token> TEST_PKGS=./commands/mr/view/... make test
  • glab mr view for two projects with and without MR approvals

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

Merge request reports