Skip to content

fix(repo list): #1327 fix filters

Jay McCure requested to merge jmc-1327 into main

Description

glab repo list was defaulting to only showing repo's that are owned by the user. This is fine when no filters were being passed as arguments, but when they were, the ownership=true filter would remain, meaning passing in --starred would only list starred projects that were owned by the user. Likewise for the --member filter.

This MR ensures that the ownership flag is only set to true if no other filters are passed.

Related Issues

Resolves #1327 (closed)

How has this been tested?

Added more tests.

Manually:

glab repo list --member --mine --starred --all
glab repo list --member --mine --starred
glab repo list --member --mine
glab repo list --member --starred
glab repo list --starred --mine
glab repo list --mine
glab repo list --member
glab repo list --all
glab repo list
glab repo list --starred

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Jay McCure

Merge request reports