Skip to content

Draft: Unset 1 second timeout for shared secrets

Mitchell Nielsen requested to merge 247-fix-slow-unit-test-failures into master

Unsets the 1 second timeout for shared secrets jobs, aiming to address this intermittent error:

• Failure [36.011 seconds]
GitLab controller Shared secrets and Self signed certificates Jobs when Both Jobs succeed [It] Should create resources for Jobs and continue the reconcile loop
/builds/gitlab-org/cloud-native/gitlab-operator/controllers/gitlab_controller_test.go:135
  Timed out after 30.001s.
  Expected
      <[]v1.ConfigMap | len:0, cap:0>: []
  not to be empty
  /builds/gitlab-org/cloud-native/gitlab-operator/controllers/gitlab_controller_test.go:164
------------------------------
STEP: Creating a new GitLab resource
STEP: Checking GitLab resource is created
STEP: Checking ServiceAccount exists for Shared secrets Job
STEP: Checking Shared secrets Job and its ConfigMap are created
2021-10-07T04:09:59.774Z	ERROR	controllers.GitLab	Timeout for Job exceeded.	{"gitlab": "cr-spec-changes.default", "job": "cr-spec-changes-shared-secrets-1-cpx", "namespace": "default", "timeout": "1s", "error": "Timeout: The Job did not finish in time"}

Note the "timeout: 1s" in the last line. We set the timeout in the CI variables, so there shouldn't be a reason to set the timeout to 1s before each test.

This change ensures that changes like !203 (diffs) actually take effect.

Closes #247 (closed)

Edited by Mitchell Nielsen

Merge request reports

Loading