Fix unit test for redis secret
What does this MR do?
- Reorder the reconciliation, it will reconcile PostgreSQL before Redis now
- Fix the unit test when the redis Secret does not exist.
We do Redis secrets tests by observing PostgreSQL. However the StatusfulSet of PostgreSQL will be created before the verification of Redis configurations. The unit tests were broken.
Additionally, we should use Consistently
instead of Eventually
with the unit test when the Redis Secret does not exist.
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Related issues
Edited by Lucas Li