Skip to content

Remove 'ci_jwt_signing_key' secret migrated to ApplicationSetting

Rémy Coutable requested to merge rymai-main-patch-f0ba into main

What does this MR do?

The secret was actually never used:

  1. Introduced in gitlab-org/gitlab!34249 (diffs) and gitlab-org/charts/gitlab!1318 (diffs)
  2. The first MR was reverted by gitlab-org/gitlab!34646 (diffs) but the second was never reverted
  3. The final solution was to add an ApplicationSetting: gitlab-org/gitlab!43950 (merged)

The secret documentation/support is also removed from gitlab at gitlab-org/gitlab!165829 (merged), charts/gitlab at gitlab-org/charts/gitlab!3910 (merged), and omnibus-gitlab at gitlab-org/omnibus-gitlab!7930 (merged).

Author's Checklist

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Ensure a release milestone is set.
  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline on GitLab.com.
  • When ready for review, MR is labeled workflowready for review per the MR workflow.

Expected

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation is created or updated.
  • Tests are added.

Related issues

gitlab-org/gitlab#451151 (closed)

Edited by Hossein Pursultani

Merge request reports

Loading