Skip to content

Validate Ed25519 key size

Mikhail Mazurskiy requested to merge ash2k/validate-key-size into master 
2024-09-09_02:37:26.27903 gitlab-k8s-agent      : panic: ed25519: bad seed length: 4
2024-09-09_02:37:26.27903 gitlab-k8s-agent      :
2024-09-09_02:37:26.27904 gitlab-k8s-agent      : goroutine 87 [running]:
2024-09-09_02:37:26.27904 gitlab-k8s-agent      : crypto/ed25519.newKeyFromSeed({0xc000e53a00, 0x40, 0x40}, {0xc0013ecc0a, 0x4, 0x6})
2024-09-09_02:37:26.27905 gitlab-k8s-agent      : 	GOROOT/src/crypto/ed25519/ed25519.go:168 +0x1f0
2024-09-09_02:37:26.27905 gitlab-k8s-agent      : crypto/ed25519.NewKeyFromSeed(...)
2024-09-09_02:37:26.27905 gitlab-k8s-agent      : 	GOROOT/src/crypto/ed25519/ed25519.go:162
2024-09-09_02:37:26.27905 gitlab-k8s-agent      : gitlab.com/gitlab-org/cluster-integration/gitlab-agent/v17/internal/module/kas2agentk_tunnel/server.(*connWorker).constructAgentConnection(0xc000e350e0)
2024-09-09_02:37:26.27906 gitlab-k8s-agent      : 	internal/module/kas2agentk_tunnel/server/connection_worker.go:193 +0x1028
2024-09-09_02:37:26.27907 gitlab-k8s-agent      : gitlab.com/gitlab-org/cluster-integration/gitlab-agent/v17/internal/module/kas2agentk_tunnel/server.(*connWorker).Run(0xc000e350e0, {0x104973d10, 0xc000ed1ae0})
2024-09-09_02:37:26.27907 gitlab-k8s-agent      : 	internal/module/kas2agentk_tunnel/server/connection_worker.go:75 +0x3c
2024-09-09_02:37:26.27907 gitlab-k8s-agent      : gitlab.com/gitlab-org/cluster-integration/gitlab-agent/v17/internal/tool/syncz.(*WorkerManager[...]).startNewWorker.func1()
2024-09-09_02:37:26.27907 gitlab-k8s-agent      : 	internal/tool/syncz/worker_manager.go:72 +0x454
2024-09-09_02:37:26.27907 gitlab-k8s-agent      : created by gitlab.com/gitlab-org/cluster-integration/gitlab-agent/v17/internal/tool/syncz.(*WorkerManager[...]).startNewWorker in goroutine 99
2024-09-09_02:37:26.27908 gitlab-k8s-agent      : 	internal/tool/syncz/worker_manager.go:56 +0x374

This can only happen if GitLab returns invalid data to kas.

Merge request reports