Skip to content

Pass gitlabshell config through to gitlab-shell from gitaly

John Cai requested to merge jc-revert-revert-ee267 into master

!2066 (merged) broke in staging because gitlab-shell saw that HTTPSettings was non-empty, and used empty values inside of it.

But now that !2104 (merged) is merged, we have protection on the ruby side against empty values.

This MR restores the original change from !2066 (merged), and also adds better test coverage for passing the config values into gitlab-shell.

Edited by GitLab Release Tools Bot

Merge request reports

Loading