Skip to content

Follow-ups for transactions

Patrick Steinhardt requested to merge pks-2pc-cleanups into master

This is two small follow-ups for transactions-related code:

  • We currently return os.ErrNotFound in case transaction or Praefect server metadata wasn't found in a the envvars/gRPC metadata. This error is misleading, as it talks about files, which is why I replace it with new errors.
  • The RNG used by the transactions code is currently not getting seeded, which is why we always get the same sequence of transaction IDs. I've converted it to use its own rand.Rand instance which is seeded via crypto/rand.

Follow up of !2147 (merged) (os.ErrNotFound) and !2182 (merged) (seeding of RNG).

Merge request reports