Skip to content

Change IsDisabled to check for explicitly disabled feature flag

John Cai requested to merge jc-change-is-disabled-ff into master

In our feature_flags package, we have IsEnabled and IsDisabled. IsDisabled does not provide much value, since all it's just a !IsEnabled. Further, there are times when we need to have a feature flag default on, which means we only want to disable a feature when a feature flag is set to "false" in the feature flags table in rails. We don't currently have a way of doing that.

This MR change IsDisabled to check for an explicitly "false" value for the feature flag.

Merge request reports