Skip to content

User{Branch,Submodule}: remove erroneously copy/pasted error handling

Ævar Arnfjörð Bjarmason requested to merge avar/remove-copy-pasted-when-an-error-happens-updateRefError-code into master

Ping: @proglottis @chriscool @pokstad1

I may be completely wrong about this, but figured I'd just send a MR to comment on instead of poking on Slack or creating an issue. See below.

I believe that this error case was copy/pasted from code that only makes sense for the UserMerge call. See f7bb6743 (operations: Port UserMergeBranch from Ruby to Go, 2020-09-09).

Since then we had this case duplicated in:

  • bf39f603 (Initial go implementation of UserFFBranch, 2020-09-22)
  • c3b32722 (Initial go implementation of UserDeleteBranch, 2020-09-29)
  • c1e3ccca (Initial go implementation of UserCreateBranch, 2020-09-30)
  • df0bf6e1 (Port UserUpdateSubmodule to Go, 2020-11-10)

I can't see any way in their Ruby code to have them return an empty response like this, but maybe I'm simply missing something.

Edited by Ævar Arnfjörð Bjarmason

Merge request reports