Skip to content

Fix improperly designed test case for command

Xing Xin requested to merge blanet/gitaly:xx/fix-improperly-designed-testcase-for-command into master

This tiny MR is part of !2990 (closed) for fixing the improperly designed TestNewCommandProxyEnv.

TestNewCommandProxyEnv is designed to prove that http proxy related envs can be whitelisted from os environment and seen by git spawn later. But the current implementation passed proxy related envs directly into New as user specified envs, making the test meaningless.

This commit fixes this by putting proxy related envs to environment using os.Setenv.

Merge request reports