golangci-lint: Add the `thelper` linter to enforce more-consistent test style
This MR adds the thelper
linter to enforce a more-consistent test style:
-
testing.T
et al should be the first parameter. We don't fully enforce this given thatcontext.Context
may still be the first parameter right now. -
testing.T
,testing.B
andtesting.TB
variables should be calledt
,b
andtb
, respectively.
Ideally, we'd also enable the linter for missing t.Helper()
calls. But as it is right now I find it rather useless as it flags too many locations as missing those calls.