Skip to content

gitaly/config: Deprecate `[gitlab-shell]` configuration section

Patrick Steinhardt requested to merge pks-config-gitlab-shell-deprecation into master

Two configuration values are derived from [gitlab-shell] dir:

  • The custom hooks directory. This can instead be explicitly configured via [hooks] custom_hooks_dir.
  • The GitLab secret file path. This can instead be explicitly configured via either [gitlab] secret or [gitlab] secret_file.

We still require that variable to be set regardless, even though it wouldn't be used in both values were handled explicitly.

This MR refactors the code suhc that configuration of the variable becomes optional in case the other two options are set and deprecates the configuration.

Part of Migrate away from `[gitlab-shell]` configuration (#4250).

Edited by Patrick Steinhardt

Merge request reports