Skip to content

Makefile: Update test-wal to call test-go

Will Chandler (ex-GitLab) requested to merge wc/make-test-wal into master

Currently the test-wal Makefile target will call the test target internally. This will run both Gitaly's Go tests and our linter tests. If overriding TEST_PACKAGES this may result in a spurious failure on the linter tests:

make test-wal TEST_PACKAGES=./internal/gitaly/storage/storagemgr
✓  internal/gitaly/storage/storagemgr (39.673s)

DONE 237 tests in 42.262s
stat /Users/wchandler/devel/gdk/gitaly/tools/golangci-lint/gitaly/internal/gitaly/storage/storagemgr: directory not found

=== Errors
stat /Users/wchandler/devel/gdk/gitaly/tools/golangci-lint/gitaly/internal/gitaly/storage/storagemgr: directory not found

DONE 0 tests, 1 error in 0.008s
make: *** [test-gitaly-linters] Error 1

Switch test-wal to use the test-go target which will skip the linter.

Edited by Will Chandler (ex-GitLab)

Merge request reports