Skip to content

build: Remove Git binaries from GITALY_PACKED_EXECUTABLES

James Liu requested to merge jliu/dont-build-git-with-notice into master

When Gitaly dependencies are updated by Renovate, it executes the make notice target [1] which is configured to also build GITALY_PACKED_EXECUTABLES. The purpose of building them is because they may also contain Go packages that we extract licences from. The Git binaries we embed are not Go projects and thus don't contribute new licence files.

Executing make notice also results in Renovate errors like [2] due to the custom base image [3] used by the Renovate runner.

Remove the Git binaries from the GITALY_PACKED_EXECUTABLES list, and modify dependent Make target to include GIT_PACKED_EXECUTABLES as a dependency so they continue to build successfully.

[1] https://gitlab.com/gitlab-org/frontend/renovate-gitlab-bot/-/blob/9a4ecfe01b8e8de6d230257396792494c78645de/renovate/gitaly/gitaly.config.js#L106

[2] !7149 (merged)

[3] https://gitlab.com/gitlab-org/frontend/renovate-gitlab-bot/-/blob/main/scripts/lib/generate-docker-files.mjs

Merge request reports

Loading