Skip to content

repository: Remove deleteInfoAttributesFile method

Eric Ju requested to merge eju/gitaly/6431/remove_deleteInfoAttributesFile into master

In !6573 (merged), we added deleteInfoAttributesFile(), this is a temporary migration logic to help us get rid of info/gitattributes files.

There are 4 gRPCs that calls deleteInfoAttributesFile(),

  • ReplicateRepository
  • GetInfoAttributes
  • ApplyGitattributes
  • GetFileAttributes

None of them has errors about "delete info/attributes file". I am pretty confident info/gitattributes file is removed from whoever called those.

Now that it has been running in prod since v17.0, it time to remove it.

As suggested at here, we can add a logic in housekeep to remove info/attributes as having "an escape hatch for users to get rid of the file if it is causing issues for them."

Closes #6431 (closed)

Edited by Eric Ju

Merge request reports