Add Google Cloud SDK to www-gitlab-com
What does this MR do
Cloud SDK
- Use Google Cloud SDK directly from standard docker image rather than downloading separate image managed by Google. Benefits:
- Speed up jobs, because we can use the standard docker image which is more likely to already be cached on a given runner (since more jobs use it)
- Speed up jobs, because even though the standard image is bigger (about 1g), it downloads in about about 30 seconds vs 1:30 for the GCP image, because it's being pulled from the gitlab Container Registry rather than Docker Hub (apparently no intermediate caching of external images is happening other than on individual runner instances)
- Allows more options for cleaning up / DRYing up deploy scripts, because we can use Ruby instead of just python/bash (which is all the GCP docker image gives us).
- Reduces the chance of future incidents like this one where they broke the performance of the docker image, because the CRC check stopped being optimized, then caused an outage because they removed the python version without a workaround. As part of that incident, Google admitted that the docker image had remaining issues and needed cleanup.
Unzip
Adds unzip
Cleanup
It also has a couple of extra misc. cleanup commits, of comments, and adding a .gitignore. These can be split to separate MRs if desired.
Testing
Tested running additional commands locally in docker image, and they result in gsutil -m rsync --help working.
Related issues
Edited by Chad Woolley