Skip to content

Don't run bin/spring stop for before stop_hooks

Ash McKenzie requested to merge 1156-gdk-restart-service-runs-bin-spring-stop into master

What does this Merge Request do?

This MR removes bin/spring stop from being run by default as part of the before stop hooks.

Before

$ gdk restart redis
ℹ️  gdk stop: before hook -> cd gitlab && bin/spring stop || true
Spring is not running
ok: down: ./services/redis: 0s
ok: run: ./services/redis: (pid 5986) 0s, normally down

After

$ gdk restart redis
ok: down: ./services/redis: 394s
ok: run: ./services/redis: (pid 5231) 1s, normally down

Merge Request checklist

  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.

Closes #1156 (closed)

Edited by Ash McKenzie

Merge request reports