Skip to content

Fix flaky config test

Ash McKenzie requested to merge ashmckenzie/fix-flaky-config-test into master

What does this Merge Request do?

I noticed the following flaky test for spec/lib/gdk/config_spec.rb:

Failures:

  1) GDK::Config pages #access_control when access_control is enabled configures auth correctly
     Failure/Error: expect(config.gitlab_pages.__auth_secret.length).to eq(32)

       expected: 32
            got: 31

       (compared using ==)
     # ./spec/lib/gdk/config_spec.rb:1126:in `block (5 levels) in <top (required)>'

Finished in 0.17548 seconds (files took 0.30269 seconds to load)
137 examples, 1 failure

Failed examples:

rspec ./spec/lib/gdk/config_spec.rb:1122 # GDK::Config pages #access_control when access_control is enabled configures auth correctly

Merge Request checklist

  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.

Merge request reports