Skip to content

Remove BUILD_TAGS on building gitaly

Takuya Noguchi requested to merge 1227-build_tags-for-gitaly into main

What does this Merge Request do and why?

Removes the pass of BUILD_TAGS on building gitaly. See also gitaly!2443 (merged).

  1. BUILD_TAGS was renamed as GO_BUILD_TAGS in the upstream (gitaly!2277 (merged))
  2. The upstream added some other features after it (gitlay!1842 and gitaly!2438 (merged))

Checklist specific to this change

  • Passed -tags "tracer_static,tracer_static_jaeger,continuous_profiler_stackdriver,static,system_libgit2" to go install before/after this change
$ cd $GDK_DIR
$ rm gitaly/.ruby-bundle
$ gdk install
[...]
Use `bundle info [gemname]` to see where a bundled gem is installed.
[...]
go install -ldflags '-X gitlab.com/gitlab-org/gitaly/internal/version.version=13.12.0-rc1-219-gc93530dd0 -X gitlab.com/gitlab-org/gitaly/internal/version.buildtime=20210520.000357' -tags "tracer_static,tracer_static_jaeger,continuous_profiler_stackdriver,static,system_libgit2" gitlab.com/gitlab-org/gitaly/cmd/gitaly-hooks gitlab.com/gitlab-org/gitaly/cmd/gitaly-debug gitlab.com/gitlab-org/gitaly/cmd/praefect gitlab.com/gitlab-org/gitaly/cmd/gitaly-git2go gitlab.com/gitlab-org/gitaly/cmd/gitaly-lfs-smudge gitlab.com/gitlab-org/gitaly/cmd/gitaly-wrapper gitlab.com/gitlab-org/gitaly/cmd/gitaly-backup gitlab.com/gitlab-org/gitaly/cmd/gitaly gitlab.com/gitlab-org/gitaly/cmd/gitaly-blackbox gitlab.com/gitlab-org/gitaly/cmd/gitaly-ssh
[...]

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Closes #1227 (closed)

Edited by Takuya Noguchi

Merge request reports