Skip to content

Fetch version files via HTTP for support/asdf-combine

Ash McKenzie requested to merge 1334-job-failed-1691373839-make-verify-asdf-combine-fails-because-gitlab-hasn-t-been-cloned-yet into main

What does this Merge Request do and why?

This MR fixes a bug where we relied upon gitlab/GITLAB_PAGES_VERSION and gitlab/GITALY_SERVER_VERSION existing on disk for support/asdf-combine to work. This is fine for a working GDK, but for CI we don't necessarily have gitlab/ checked out, so we need to fetch the needed files via HTTP. When support/asdf-combine is run it displays:

$ support/asdf-combine
https://gitlab.com/gitlab-org/gitlab-pages/-/raw/v1.46.0/.tool-versions
-----------------------------------------------------------------------
golang 1.16.9
https://gitlab.com/gitlab-org/gitaly/-/raw/4f0a07ba39f14adacf7d482128a5de2bb84f0eac/.tool-versions
--------------------------------------------------------------------------------------------------
golang 1.17.1 1.16.8
ruby 2.7.4
https://gitlab.com/gitlab-org/gitlab-ui/-/raw/main/.tool-versions
-----------------------------------------------------------------
nodejs 14.17.5
yarn 1.22.11
https://gitlab.com/gitlab-org/gitlab-docs/-/raw/main/.tool-versions
-------------------------------------------------------------------
ruby 2.7.4
nodejs 14.17.5
yarn 1.22.11

We now also fire the verify-asdf-combine CI job if changes are detected for:

  • .tool-versions*
  • support/asdf-combine
  • support/ci/verify-asdf-combine

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Closes #1334 (closed)

Edited by Ash McKenzie

Merge request reports