Skip to content

Fix reconfigure to use GITLAB_ELASTICSEARCH_INDEXER_VERSION version

Terri Chu requested to merge tchu-allow-gdk-reconfigure-to-pull-different-branch-elasticsearch-indexer into main

What does this Merge Request do and why?

What

Change behavior for gdk reconfigure for gitlab-elasticsearch-indexer to use version specified in GITLAB_ELASTICSEARCH_INDEXER_VERSION and add additional print statements to output.

Current behavior:

  • clone branch
  • build gitlab-elasticsearch-indexer

New behavior:

  • clone branch
  • git fetch
  • git checkout version referenced from GITLAB_ELASTICSEARCH_INDEXER_VERSION in gitlab folder
  • build gitlab-elasticsearch-indexer

Why

This will make it easier to test a different version of the gitlab-elasticsearch-indexer. Currently the checkout and build steps must be done manually and gdk update checks out the master branch (effectively overwriting any changes to the GITLAB_ELASTICSEARCH_INDEXER_VERSION file)

Once this is updated, I will update documentation to add a new way to test in gdk in the gitlab-elasticsearch-indexer project

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Terri Chu

Merge request reports