Skip to content

Use GDK hostname for vault address

Albert requested to merge alberts-use-gdk-hostname-for-vault into main

What does this merge request do and why?

Use GDK hostname for vault address.

The runner uses the vault address to call Vault and fetch the secret. Given that the runner's executor could be running in Docker network, it needs to be able to call a service on the host machine. Using GDK's config.hostname ensures that runner will be able to reach Vault, since this is the same address used by Rails.

https://gitlab.com/gitlab-org/gitlab-development-kit/blob/main/doc/howto/runner.md#set-up-a-local-network

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Albert

Merge request reports

Loading