Resolve "GDK reconfigure not configuring praefect, gitlab-shell, and gitlab-workhorse"

What does this merge request do and why?

This MR fixes a bug where gdk reconfigure was not looking to update all config files.

How to set up and validate locally

Using the main branch

Run the following and you'll see the # REMOVE ME output, which shouldn't be there:

$ echo "# REMOVE ME" >> gitaly/praefect.config.toml ; touch support/templates/gitaly/praefect.config.toml.erb ; bundle exec rake reconfigure ; grep -H '# REMOVE ME' gitaly/praefect.config.toml
gitaly/praefect.config.toml:# REMOVE ME

Using this branch, 1784-gdk-reconfigure-not-configuring-praefect-gitlab-shell-and-gitlab-workhorse

Run the following and you should see no output, which is correct:

$ echo "# REMOVE ME" >> gitaly/praefect.config.toml ; touch support/templates/gitaly/praefect.config.toml.erb ; bundle exec rake reconfigure ; grep -H '# REMOVE ME' gitaly/praefect.config.toml

ℹ️ Ideally, running the rake reconfigure command should output warnings when updating files, but for gitaly/praefect.config.tom it isn't but will be fixed with !3050 (merged).

Impacted categories

The following categories relate to this merge request:

• gdk-reliability - e.g. When a GDK action fails to complete.
• gdk-usability - e.g. Improvements or suggestions around how the GDK functions.
• gdk-performance - e.g. When a GDK action is slow or times out.

Merge request checklist

• This change is backward compatible. If not, please include steps to communicate to our users.
• Tests added for new functionality. If not, please raise an issue to follow-up.
• Documentation added/updated, if needed.
• Announcement added, if change is notable.
• gdk doctor test added, if needed.
• Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Closes #1784 (closed)