Fix Vite HMR for installs without NGINX
What does this merge request do and why?
!3594 (merged)
fixed the Vite HMR so that host
would actually be used, but this
broke GDK installations that do not use NGINX since Vite listens only
on config.listen_address
(e.g. 127.0.0.1
) by default. If NGINX
isn't used, we have to point the HMR to config.listen_address
instead of config.hostname
.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.
Edited by Stan Hu