Diversify errors in Error Tracking
What does this merge request do and why?
Error Tracking groups errors by the following criteria:
- Exception class
- Location of first backtrace frame
Since Telemetry.capture_exception
is called by GDK::Output.error
and
GDK::Output.abort
the errors were grouped incorrectly due to the first
frame being almost always the same.
This commit drops the first frame to ensure that errors are created from distinct locations.
How to set up and validate locally
- Run the following GDK commands
gdk config get foo
gdk rails
- Watch
Events
increase in
- https://gitlab.com/gitlab-org/developer-relations/contributor-success/lee-testing/error-tracking-test/-/error_tracking
- OR https://gitlab.com/gitlab-org/gitlab-development-kit/-/error_tracking when !3763 (merged) is merged
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.
Edited by Peter Leitzen