Skip to content

Drop RE2 diagnostic

Stan Hu requested to merge sh-drop-re2-diagnostic into main

What does this merge request do and why?

Since re2 v2.0 (https://ruby.social/@mudge/111059216711881571), the gem now ships with precompiled native gems shipped with all batteries included so macOS and Linux users no longer need the libre2 system library to be installed. A a result, the diagnostic no longer is needed and can lead to false positives when bundle install is needed in the GitLab Rails directory.

How to set up and validate locally

Run gdk doctor with a gem missing in gitlab/. re2 should no longer be mentioned.

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Stan Hu

Merge request reports

Loading