Skip to content

Add ports for HTTP router, Nginx, and Workhorse in devfile

Nao Hashizume requested to merge 2183-add-http-router-endpoint into main

What does this merge request do and why?

Add ports for HTTP router, Nginx, and Workhorse in the devfile to make sure they are accessible in remote development workspace.

This change fixes the [ERROR] Error in ProxyController: Error inside ProxyWorker issue. The error occurred because HTTP router had GITLAB_PROXY_HOST set to the config.workhorse.__listen_address, but that port wasn't accessible. For example, the gitlab-http-router/wrangler.toml had:

--snip--
[env.dev]
name = "dev-cells-http-router"
vars = { GITLAB_PROXY_HOST = "10.20.0.91:3333", GITLAB_RULES_CONFIG = "passthrough" }
--snip

Closes #2183 (closed)

How to set up and validate locally

  1. Create a new workspace at https://gitlab.com/-/remote_development/workspaces/new?project=gitlab-org%2Fgitlab-development-kit.
  2. Choose 2183-add-http-router-endpoint as the Git reference.
  3. Click Create workspace.

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Nao Hashizume

Merge request reports