Add nil check for @start to avoid errors when report_start isn't called
What does this merge request do and why?
Update print_report!
to include a nil check for @start
. Without this, if report_start
isn't called before print_report!
, @start
remains nil and causes a TypeError when trying to subtract nil from Time.now
. With this change, print_report!
avoids showing the total duration when @start
is nil.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.
Edited by Nao Hashizume