Skip to content

Fix PackageHelper#extract_entry to skip empty directories

Nao Hashizume requested to merge 2202-skip-empty-directories into main

What does this merge request do and why?

Fix an issue where extract_entry method was adding an empty directory as found in !4023 (comment 2097157668).

It now skips unnecessary directory entries and extracts only required files.

Related to #2202 (closed)

How to set up and validate locally

  1. Run git checkout 2202-skip-empty-directories
  2. Apply changes from !4023 (merged) with git diff kkloss-use-packagehelper-for-graphql-download | git apply
  3. Run bundle exec rake update:graphql
  4. Verify there's no empty graphql directory by running ls gitlab/tmp/tests/graphql

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Merge request reports

Loading