Fix PackageHelper#extract_entry to skip empty directories
What does this merge request do and why?
Fix an issue where extract_entry
method was adding an empty directory as found in !4023 (comment 2097157668).
It now skips unnecessary directory entries and extracts only required files.
Related to #2202 (closed)
How to set up and validate locally
- Run
git checkout 2202-skip-empty-directories
- Apply changes from !4023 (merged) with
git diff kkloss-use-packagehelper-for-graphql-download | git apply
- Run
bundle exec rake update:graphql
- Verify there's no empty
graphql
directory by runningls gitlab/tmp/tests/graphql
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.